Add By Day, By Hour, and Timing stats charts; fix symptom time tracking#126
Merged
Conversation
syncSymptomsToTrackingLog() always passed an empty loggedAt, so the Symptoms category's trackAgainstTime flag was silently ignored for any entry saved from the period log screen. https://claude.ai/code/session_018JqDNoQmTRpYxFJJ9kVhw8
ChartDataComputer and DashboardScreen both had exhaustive when expressions over ChartType / StatsChartData that didn't cover the three new WEEKDAY, TIME_OF_DAY, and TIME_CORRELATION cases. https://claude.ai/code/session_018JqDNoQmTRpYxFJJ9kVhw8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix: Symptoms logged from the period log screen now record the time when the Symptoms category has "Track against time" enabled.
syncSymptomsToTrackingLog()was always passing an emptyloggedAt, silently ignoring thetrackAgainstTimeflag.Feature: Three new chart types in the Stats screen, all accessible from the "Chart type" selector:
Test plan
loggedAttimehttps://claude.ai/code/session_018JqDNoQmTRpYxFJJ9kVhw8