Fix: slider logs with default value can't be saved#133
Merged
Conversation
Previously, save() returned early when numericValue was null, which is the state for a freshly opened slider entry even though the slider UI already shows numericMin as the displayed value. Fall back to category.numericMin so the displayed default is what gets saved. https://claude.ai/code/session_01TFJgN6FrGieSumycWapWA7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numericMinas its default value, butLogCategoryViewModel.numericValuestaysnulluntil the user drags the slider.save()treatednumericValue == nullas "nothing to save" and returned early, so tapping Save without touching the slider silently did nothing.category.numericMin(the value already shown to the user) whennumericValueis null.Changes
LogCategoryViewModel.kt: fix the early-return insave()fornumeric_slider0.47.2-beta.1(versionCode 102) + changelog entryLESSONS.md: added a transferable lesson about null "not yet interacted" state vs. save validationTest plan
Generated by Claude Code