feat(file_browser): add filter param for regex and callable filtering#9667
Open
kratos0718 wants to merge 2 commits into
Open
feat(file_browser): add filter param for regex and callable filtering#9667kratos0718 wants to merge 2 commits into
kratos0718 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Closes marimo-team#8399 Signed-off-by: Abhinav Tarigoppula <abhinav@Abhinavs-MacBook-Air.local>
kratos0718
force-pushed
the
feat/file-browser-filter-param
branch
from
0c837e0 to
4888d06
Compare
for more information, see https://pre-commit.ci
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Hi, just following up on this PR. |
Author
|
Hi! Just checking in — all automated checks are passing and CLA is signed. Happy to make any requested changes or incorporate feedback. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8399
📝 Summary
Adds a
filterkeyword argument tomo.ui.file_browser()so users can filter files using regex patterns or custom functions — not just file extensions.Three ways to use it:
filter=r"^train_"filter=re.compile(r"\.csv$", re.IGNORECASE)filter=lambda p: p.stat().st_size > 1_000_000Directories are always shown for navigation. Works together with
filetypesandignore_empty_dirs.Merge Checklist