Skip to content

add opus 4.8 and script to append models to the top#9723

Open
Light2Dark wants to merge 3 commits into
mainfrom
sham/add-opus-4-8
Open

add opus 4.8 and script to append models to the top#9723
Light2Dark wants to merge 3 commits into
mainfrom
sham/add-opus-4-8

Conversation

@Light2Dark
Copy link
Copy Markdown
Collaborator

@Light2Dark Light2Dark commented May 29, 2026

📝 Summary

Used to append at the bottom of each provider, now push to the top

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.

Copilot AI review requested due to automatic review settings May 29, 2026 10:20
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment May 29, 2026 10:43am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the LLM model sync workflow so newly discovered models are inserted at the top of existing provider sections, and adds the latest synced model entries to the catalog.

Changes:

  • Renames the existing document merge helper from append-oriented wording to insert-oriented wording.
  • Prepends newly synced models before curated provider entries while preserving blank-line formatting.
  • Adds new Anthropic, Bedrock, and opencode-go model entries and updates the sync test expectation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/llm-info/src/sync-models.ts Changes existing-section insertion to prepend new model entries.
packages/llm-info/src/__tests__/sync-models.test.ts Updates the sync test to assert prepended ordering.
packages/llm-info/data/models.yml Adds new model catalog entries near the top of their provider sections.

Comment thread packages/llm-info/src/sync-models.ts
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/llm-info/data/models.yml">

<violation number="1" location="packages/llm-info/data/models.yml:214">
P2: Missing non-global variant for Claude Opus 4.8 in bedrock. Opus 4.7 has both `anthropic.claude-opus-4-7` and `global.anthropic.claude-opus-4-7`. Only the global variant was added for Opus 4.8. If the non-global variant is also available, add it.</violation>
</file>
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant Script as syncModels CLI
    participant API as Models Dev API
    participant Parser as YAML Parser
    participant File as models.yml

    Note over Dev,File: NEW model registration flow

    Dev->>Script: run syncModels()
    Script->>API: fetch latest models
    API-->>Script: model definitions list
    Script->>Script: filter & cap new entries per provider

    alt has existing YAML file
        Script->>Parser: parse existing models.yml
        Parser-->>Script: YAML document tree
        Script->>Script: insertIntoDocument()
        Note over Script: prepend new models to each <br/>provider section (not append)
        Script->>Script: build YAML map nodes
        Script->>Script: preserve blank line between <br/>new block and curated entries
        Script->>File: write updated YAML
    else fresh file
        Script->>Script: renderFresh()
        Script->>File: write complete YAML
    end

    File-->>Dev: updated models.yml with new models at top

    Note over Dev,File: Example: anthropic gets Claude Opus 4.8 <br/>prepended above existing Opus 4.7
Loading

Reply with feedback, questions, or to request a fix.

Re-trigger cubic


bedrock:

- name: Claude Opus 4.8 (Global)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Missing non-global variant for Claude Opus 4.8 in bedrock. Opus 4.7 has both anthropic.claude-opus-4-7 and global.anthropic.claude-opus-4-7. Only the global variant was added for Opus 4.8. If the non-global variant is also available, add it.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/llm-info/data/models.yml, line 214:

<comment>Missing non-global variant for Claude Opus 4.8 in bedrock. Opus 4.7 has both `anthropic.claude-opus-4-7` and `global.anthropic.claude-opus-4-7`. Only the global variant was added for Opus 4.8. If the non-global variant is also available, add it.</comment>

<file context>
@@ -199,6 +210,17 @@ google:
 
 bedrock:
+
+  - name: Claude Opus 4.8 (Global)
+    model: global.anthropic.claude-opus-4-8
+    description: "Modest but tangible improvement over Claude Opus 4.7"
</file context>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't add it for now. Could see if users want that too. The global variant is the most available for all regions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context—understood.

Comment thread packages/llm-info/src/sync-models.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants