Rename LICENSE.md to LICENSE for better compatibility with Bazel tooling#3950
Merged
UziTech merged 1 commit intomarkedjs:masterfrom Apr 19, 2026
Merged
Rename LICENSE.md to LICENSE for better compatibility with Bazel tooling#3950UziTech merged 1 commit intomarkedjs:masterfrom
UziTech merged 1 commit intomarkedjs:masterfrom
Conversation
Starting with aspect_rules_js 3.x, the default npm packaging behavior excludes Markdown files (for example, *.md) from generated package contents. As a result, packages that ship their license exclusively as LICENSE.md are no longer picked up by Bazel-based license collection pipelines. This affects downstream consumers such as Gerrit Code Review, which relies on Bazel tooling to aggregate third-party licenses from node_modules. In this setup, marked was the only dependency whose license was omitted, because it was provided solely as LICENSE.md. Rename the file to LICENSE so the package license is preserved in Bazel-generated npm package directories and can be detected by license aggregation and compliance tooling. This is a packaging-only change and does not affect runtime behavior. Fixes markedjs#3949 Refs: aspect-build/rules_js#2806
|
@davido is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
UziTech
approved these changes
Apr 19, 2026
Member
|
Does this need to be pushed to NPM or will it work to just update the repo and let this be pushed to NPM in the next release? |
Contributor
Author
|
It's fully sufficient to be included in the next regular NPM release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with aspect_rules_js 3.x, the default npm packaging behavior excludes Markdown files (for example, *.md) from generated package contents.
As a result, packages that ship their license exclusively as LICENSE.md are no longer picked up by Bazel-based license collection pipelines.
This affects downstream consumers such as Gerrit Code Review, which relies on Bazel tooling to aggregate third-party licenses from node_modules. In this setup, marked was the only dependency whose license was omitted, because it was provided solely as LICENSE.md.
Rename the file to LICENSE so the package license is preserved in Bazel-generated npm package directories and can be detected by license aggregation and compliance tooling.
This is a packaging-only change and does not affect runtime behavior.
Fixes #3949
Refs: aspect-build/rules_js#2806
Marked version:
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.