Skip to content

refactor(test): move task list output coverage to specs#3963

Merged
UziTech merged 1 commit intomarkedjs:masterfrom
AbdelrahmanHafez:refactor/move-marked-output-tests
May 2, 2026
Merged

refactor(test): move task list output coverage to specs#3963
UziTech merged 1 commit intomarkedjs:masterfrom
AbdelrahmanHafez:refactor/move-marked-output-tests

Conversation

@AbdelrahmanHafez
Copy link
Copy Markdown
Contributor

Marked version: 18.0.3

Markdown flavor: GitHub Flavored Markdown

Description

re #3960 (review).

Moves basic task-list Markdown-to-HTML coverage from test/unit/marked.test.js to test/specs/new, matching the review comment above.

Kept the scope narrow after a project-wide scan. Other HTML assertions remain in unit tests because they cover API behavior.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

@AbdelrahmanHafez is attempting to deploy a commit to the MarkedJS Team on Vercel.

A member of the Team first needs to authorize it.

@AbdelrahmanHafez AbdelrahmanHafez marked this pull request as ready for review May 2, 2026 13:56
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates task list unit tests from marked.test.js to a spec-based format. It introduces new markdown and HTML spec files for tight and loose task lists while removing the equivalent unit tests from the JavaScript test suite. I have no feedback to provide.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marked-website Ready Ready Preview, Comment May 2, 2026 2:48pm

Request Review

@UziTech UziTech merged commit 1731d38 into markedjs:master May 2, 2026
8 checks passed
@AbdelrahmanHafez AbdelrahmanHafez deleted the refactor/move-marked-output-tests branch May 2, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants