refactor(test): move task list output coverage to specs#3963
Merged
UziTech merged 1 commit intomarkedjs:masterfrom May 2, 2026
Merged
Conversation
|
@AbdelrahmanHafez is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates task list unit tests from marked.test.js to a spec-based format. It introduces new markdown and HTML spec files for tight and loose task lists while removing the equivalent unit tests from the JavaScript test suite. I have no feedback to provide.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
UziTech
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.0.3
Markdown flavor: GitHub Flavored Markdown
Description
re #3960 (review).
Moves basic task-list Markdown-to-HTML coverage from
test/unit/marked.test.jstotest/specs/new, matching the review comment above.Kept the scope narrow after a project-wide scan. Other HTML assertions remain in unit tests because they cover API behavior.
Contributor
Committer
In most cases, this should be a different person than the contributor.