Making word-export more versatile#22
Open
iwantwin wants to merge 1 commit intomarkswindoll:masterfrom
Open
Conversation
- Returning the blob since we might want to use it in our code - Making the autoSaveAs optional, sometimes we want to simply get a blob and handle saving ourselves. Use case where I needed it: I needed to create a zip folder with js-zip, and wanted to save .doc files inside the zip folder. Therefor, I needed the blobs create by word-export. I was never going to save the doc files, I wanted to save the zip file. This commit performs the necessary changes to support such a use case, and is also 100% backwards compatible.
xcomx
approved these changes
Dec 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case where I needed it: I needed to create a zip folder with js-zip, and wanted to save .doc files inside the zip folder. Therefor, I needed the blobs create by word-export. I was never going to save the doc files, I wanted to save the zip file. This commit performs the necessary changes to support such a use case, and is also 100% backwards compatible.