Conversation
|
Warning Rate limit exceeded@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "APP_PORT", | ||
| 8000, | ||
| path="port", | ||
| resolution=resolution, | ||
| transform=lambda value: _to_int(value, 8000), |
There was a problem hiding this comment.
Restore transform support in _get_env_value
After the refactor _get_env_value in _app_config_utils no longer accepts a transform callback, but AppConfig.from_env still calls it with transform=lambda value: _to_int(value, 8000) and similar lambdas. Constructing an AppConfig now immediately fails with TypeError: _get_env_value() got an unexpected keyword argument 'transform', so the application cannot load configuration from the environment. Reintroduce the transform parameter (and apply it to the retrieved string) or remove these arguments from the call sites.
Useful? React with 👍 / 👎.
Summary
src/core/config/_app_config_utils.pyand import them fromapp_config.pysrc/core/config/_app_config_models.pysrc/core/config/app_config.pyby re-exporting the new helpers and models, leaving theAppConfigdefinition focused on configuration assemblyTesting
python -m pytest -n0(fails: ModuleNotFoundError: No module named 'pytest_mock')Codex Task