Conversation
|
Warning Rate limit exceeded@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def model_is_functional(self, model_id: str) -> bool: | ||
| """Check if a model is available in any functional backend.""" | ||
| return self.backends.model_is_functional(model_id) |
There was a problem hiding this comment.
Reintroduce BackendSettings.model_is_functional
AppConfig.model_is_functional now delegates to self.backends.model_is_functional, but the refactor moved BackendSettings to _app_config_models.py without carrying over its model_is_functional method. Because BackendSettings.__getattr__ returns a BackendConfig for unknown attributes, this call now produces a BackendConfig object and raises TypeError: 'BackendConfig' object is not callable. Any code that checks whether a backend/model is functional will crash. Restore the helper on BackendSettings so the method call continues to work.
Useful? React with 👍 / 👎.
Summary
src/core/config/_app_config_utils.pyand import them fromapp_config.pysrc/core/config/_app_config_models.pysrc/core/config/app_config.pyby re-exporting the new helpers and models, leaving theAppConfigdefinition focused on configuration assemblyTesting
python -m pytest -n0(fails: ModuleNotFoundError: No module named 'pytest_mock')Codex Task