Skip to content

remove additional condition on update button for consistent vis #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minhsueh merged 2 commits into from
Mar 6, 2026
Merged

remove additional condition on update button for consistent vis #515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e6276
remove additional condition on update button for consistent vis
minhsueh Mar 6, 2026
43770ba
Merge branch 'main' into phonon-update
minhsueh Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions crystal_toolkit/components/phonon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,14 +1100,13 @@ def update_crystal_animation(
num_sites = struct.num_sites

# update structure if the controls got triggered
if sueprcell_update:
total_repeat_cell_cnt = scale_x * scale_y * scale_z
total_repeat_cell_cnt = scale_x * scale_y * scale_z

# create supercell
trans = SupercellTransformation(
((scale_x, 0, 0), (0, scale_y, 0), (0, 0, scale_z))
)
struct = trans.apply_transformation(struct)
# create supercell
trans = SupercellTransformation(
((scale_x, 0, 0), (0, scale_y, 0), (0, 0, scale_z))
)
struct = trans.apply_transformation(struct)

struc_graph = StructureGraph.from_local_env_strategy(struct, CrystalNN())

Expand Down
Loading