ENH: stoppable background tasks by simple set_stop_event method on tasks#406
Open
jotelha wants to merge 1 commit intomaterialsproject:mainfrom
Open
ENH: stoppable background tasks by simple set_stop_event method on tasks#406jotelha wants to merge 1 commit intomaterialsproject:mainfrom
jotelha wants to merge 1 commit intomaterialsproject:mainfrom
Conversation
Member
|
Hi, The initial (default) purpose of a background task was to run a process repeatedly at some interval - e.g., every 60 seconds or so - while the main task was running. For example, you might want to repeatedly check the progress of an output file every 60 seconds and update a secondary database with the result. If you are using the BackgroundTask to establish an ssh connection, does it still stay running indefinitely if:
Note that having some kind of external stop event might still make sense (and maybe we want to make this more official by having it be an explicit parameter of BackgroundTask), but just wanted to probe a little more into the situation first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks wrapped into BackgroundTask might run forever (In my particular case, I use background tasks to establish some ssh connection, i.e. for file transfer to remote machines. The ssh connection stays open as long as Fireworks itself runs, even if the connection-dependent file transfer task has finished, blocking the allocated port indefinitely). Give them an opportunity to exit gracefully by suggesting any such task to implement some
set_stop_eventmethod and forward the stop event if this method exists. A very simple approach.