Skip to content

CI: Harden GHA configuration#85

Merged
mfisher87 merged 9 commits into
matplotlib:mainfrom
tacaswell:harden_gha
Jun 2, 2026
Merged

CI: Harden GHA configuration#85
mfisher87 merged 9 commits into
matplotlib:mainfrom
tacaswell:harden_gha

Conversation

@tacaswell
Copy link
Copy Markdown
Member

Apply recommended hardening steps including:

  • pinning to a SHA any actions used
  • not persisting the read token on checkout
  • setting the default permissions
  • adding a depandabot file for GHA

@tacaswell
Copy link
Copy Markdown
Member Author

The failures look like real test failures, not due these CI changes.

tacaswell added 4 commits June 2, 2026 16:22
This eliminates the possibility of a tag being changed under
us.
May include:

- Avoids risky string interpolation.
- Prevents checkout premissions from leaking
Reduces risk of arbitrary code is run by attacker.
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/release.yml Fixed
Comment thread .github/workflows/release.yml Fixed
Comment thread .github/workflows/release.yml Fixed

- name: "Publish to PyPI"
uses: "pypa/gh-action-pypi-publish@release/v1"
uses: "pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b" # v1.14.0
@mfisher87 mfisher87 self-requested a review June 2, 2026 22:38
Copy link
Copy Markdown
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mfisher87 mfisher87 merged commit 5ab12b2 into matplotlib:main Jun 2, 2026
9 checks passed
@tacaswell tacaswell deleted the harden_gha branch June 3, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants