Skip to content

fix(ui): Sending read receipt in live timeline uses threaded event id instead #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmartinesp merged 8 commits into from
Nov 18, 2025
Merged

fix(ui): Sending read receipt in live timeline uses threaded event id instead #5864

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
635313a
fix(ui): Sending read receipt in live timeline when latest event is i…
jmartinesp Nov 13, 2025
543eefb
fix(test): Fix broken test locally: it was using a previous cached va…
jmartinesp Nov 13, 2025
6eec020
fix clippy
jmartinesp Nov 13, 2025
238f06e
test: Add test for `TimelineController::latest_event_id`
jmartinesp Nov 14, 2025
487b842
reafactor(ffi): Have `ffi::Timeline::latest_event_id` use `ui::Timeli…
jmartinesp Nov 14, 2025
92a3d3a
doc: Fix docs for `ffi::Timeline::latest_event_id`
jmartinesp Nov 14, 2025
4e1f5b9
doc: Improve doc comments
jmartinesp Nov 18, 2025
ee2eca3
doc: add changelogs
jmartinesp Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/matrix-sdk-ffi/src/timeline/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ impl Timeline {

/// Returns the [`EventId`] of the latest event in the timeline.
pub async fn latest_event_id(&self) -> Option<String> {
self.inner.latest_event().await.and_then(|event| event.event_id().map(ToString::to_string))
self.inner.latest_event_id().await.as_deref().map(ToString::to_string)
}

/// Queues an event in the room's send queue so it's processed for
Expand Down
7 changes: 6 additions & 1 deletion crates/matrix-sdk-ui/src/timeline/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ impl Timeline {
Some(item.to_owned())
}

/// Get the latest of the timeline's event items.
/// Get the latest of the timeline's event items, both remote and local.
pub async fn latest_event(&self) -> Option<EventTimelineItem> {
if self.controller.is_live() {
self.controller.items().await.iter().rev().find_map(|item| {
Expand All @@ -268,6 +268,11 @@ impl Timeline {
}
}

/// Get the latest of the timeline's event ids.
Copy link
Member

@Hywan Hywan Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to precise that, contrary to latest_event, this method only returns the ID of the last remote event (which is obvious for us because a local event doesn't have an event ID, only a transaction ID, but it's better to make it clear.

pub async fn latest_event_id(&self) -> Option<OwnedEventId> {
self.controller.latest_event_id().await
}

/// Get the current timeline items, along with a stream of updates of
/// timeline items.
///
Expand Down
Loading