Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 17, 2025

This PR makes the following changes to the Swift xtask:

  • Add support for building Tier 3 targets (by using nightly and -Zbuild-std).
  • Add the watchos targets (I ignored armv7k-apple-watchos as the last supported device with that was the Series 3 which is became unsupported as of watchOS 9).
  • Add a CLI flag to include the tier 3 targets when building all targets (which are ignored by default).
  • Add a linker workaround for watchOS simulator builds.

@pixlwave pixlwave requested a review from a team as a code owner November 17, 2025 11:18
@pixlwave pixlwave requested review from poljar and removed request for a team November 17, 2025 11:18
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.61%. Comparing base (9ab886f) to head (17495e7).
⚠️ Report is 29 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5872      +/-   ##
==========================================
+ Coverage   88.59%   88.61%   +0.01%     
==========================================
  Files         363      363              
  Lines      102888   102888              
  Branches   102888   102888              
==========================================
+ Hits        91153    91171      +18     
+ Misses       7496     7477      -19     
- Partials     4239     4240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #5872 will not alter performance

Comparing doug/watchos (17495e7) with main (5d396e4)

Summary

✅ 50 untouched

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, can't spot anything wrong with it and I trust you didn't break your own build 😅

@poljar poljar merged commit 0b5e1fb into main Nov 19, 2025
53 checks passed
@poljar poljar deleted the doug/watchos branch November 19, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants