Spaces: Fix removing a space child when the relationship is only 1-way.

[pixlwave]

Seconds before #5871 auto-merged, I noticed that removing a child from a space where only the m.space.parent was set would never work as I copy & pasted an early return to fix #5871 (comment) instead of using an if { } else { }.

Then I noticed there were no tests for removing the child…

Then I noticed that the removal was checking if the m.space.child/parent result was Ok without checking if the event was Some.

Long story short, this PR fixes it all 🤦‍♂️

[codspeed-hq]

CodSpeed Performance Report

Merging #5890 will not alter performance

_{Comparing doug/spaces-fix (be7699e) with main (ae90708)}

Summary

✅ 27 untouched
⏩ 23 skipped¹

Footnotes

1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[stefanceriu]

Oupsie 🙃

[codecov]

Codecov Report

❌ Patch coverage is 98.92473% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.64%. Comparing base (ae90708) to head (be7699e).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/matrix-sdk-ui/src/spaces/mod.rs	98.92%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5890      +/-   ##
==========================================
+ Coverage   88.61%   88.64%   +0.03%     
==========================================
  Files         362      362              
  Lines      103070   103146      +76     
  Branches   103070   103146      +76     
==========================================
+ Hits        91331    91436     +105     
+ Misses       7496     7462      -34     
- Partials     4243     4248       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefanceriu]

Benchmarks are failing with a 503 on curl -fsSL https://github.com/CodSpeedHQ/runner/releases/download/v$RUNNER_VERSION/codspeed-runner-installer.sh | bash -s -- --quiet (duh) so I'll just go ahead and merge it.