fix(sidebar): prevent null responses from sidebar API endpoints#974
fix(sidebar): prevent null responses from sidebar API endpoints#974DHRUVI5674 wants to merge 1 commit intomattermost:masterfrom
Conversation
… returned instead of nil
|
Hello @DHRUVI5674, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
Fixes #235
Summary
Sidebar API endpoints sometimes returned
nullwhen GitHub API calls failed or returned unexpected data. This caused the Mattermost webapp sidebar to crash.Changes
nilingetUnreadsDatagetSidebarDatareturns defaultSidebarContenton errorTesting
Result
The sidebar no longer crashes when API endpoints return null or fail unexpectedly.
Type of change