Disable npm caching in release workflow#1718
Conversation
zizmor flags cache-poisoning in workflows that publish artifacts: a poisoned cache entry restored during a release run could taint the published package. Disable setup-node's package manager cache in release.yml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now disables package manager caching in the Node setup for both the build and publish jobs by adding ChangesRelease Workflow Caching
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
zizmor reports
cache-poisoningfindings forrelease.yml(it has arelease: publishedtrigger and publishes to npm): a poisoned cache entry restored during a release run could taint the published package. This disables setup-node's package-manager cache in both jobs of that workflow.This also closes the open zizmor code-scanning alerts on
release.yml, which would otherwise fail the code-scanning check on any future PR touching those lines.🤖 Generated with Claude Code
Summary by CodeRabbit