feat: add opensearch endpoints powered by quicksearch#391
Open
LeoMcA wants to merge 2 commits into
Open
Conversation
globau
requested changes
Jun 22, 2026
| res | ||
| .status(200) | ||
| .setHeader("Content-Type", "application/x-suggestions+json; charset=utf-8") | ||
| .setHeader("Cache-Control", "public, max-age=3600"); |
There was a problem hiding this comment.
If the search backend fails, this will return HTTP/200 with an empty result that is cached for an hour.
Either return a http error, or don't cache when an error occurs.
|
|
||
| return indexResults | ||
| .map((i) => index.items[i]) | ||
| .filter((item) => item !== undefined); |
There was a problem hiding this comment.
This is different from fred, which does:
return indexResults.map((i) => i && (index.items || [])[i]).filter(Boolean);
Which skips the first element. I'm not sure which is correct; it seems non-accidental in fred and has been in prod for a while.
In any event, make sure the funcs in the two repos match, or add a comment explaining the divergence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of mdn/fred#1079
Ports quicksearch in fred into the cloud function, for use from OpenSearch:
opensearch.xmlfrom fred, in order to control locales: opted for simplicity here, adding the locale as a query, so the added search engine matches the locale of the page the user adds it from, rather than doing accept-language negotiation at query timeBASE_URL_MAINso it's possible to test this locally, with fred and the cloud function running on different ports