Fix GPS/Buzzer toggle UI popup #1203
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidraver
force-pushed
the
fix-gps-popup
branch
from
26ff8be to
e855706
Compare
Contributor
Author
|
(this PR moves the buzzer alert after saveprefs too because it exhibits the same bug) |
Contributor
Author
|
sorry to always poke you @fdlamotte but can this be merged before the next release? the popups looking awful now on dev :) |
Member
|
Thank you :) I noticed this on my unit too. |
Collaborator
|
yes this was definitely necessary ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving GPS state to flash introduced a small bug. (PR #1156)
The act of saving GPS preferences consumed most of the alert popup time so the screen only showed GPS: On / GPS: Off for a very brief period, not the full 800msec that was intended.
Moving alerts after saveprefs solves this.