Security Fixes: Buffer Overflow Prevention and Packet Validation #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation - Issue meshcore-dev#3: Replace all strcpy/sprintf with strncpy/snprintf to prevent buffer overflows * Fixed CommonCLI.cpp: All command responses now use bounded string operations * Fixed RegionMap.cpp: Safe string copying for wildcard name * Removed password echoing (security issue) - Issue meshcore-dev#7: Improve Packet::readFrom() validation * Add bounds checking before all memory operations * Validate minimum packet size upfront * Check transport codes fit in buffer before copying * Verify path_len and payload_len before memcpy * Prevent buffer overruns from malformed packets
Contributor
|
wow, readFrom() buffer overflow sounds plausible, that is the one that can be exploited without authentication I would focus only on that at first. The others are.... already expecting a serial or admin access, so low priority IMHO. also can't find MAX_SERIAL_MSG_SIZE deifned anywhere, where did you get it? |
Author
|
I did not define it, it should be 160. |
- Matches the buffer size used in all example applications - Required for the bounded string operations added in security fixes
jbrazio
reviewed
Dec 12, 2025
| #define WITH_BRIDGE | ||
| #endif | ||
|
|
||
| #define MAX_SERIAL_MSG_SIZE 160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses two critical security vulnerabilities identified in the MeshCore codebase: