Skip to content

Conversation

@M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented May 12, 2025

Notes for Reviewers

To close a shape, the user can now use just the Enter key instead of using CTRL+Enter

Signed commits

  • Yes, I signed my commits.

@M-DEV-1 M-DEV-1 changed the title Fix: Change CTRL+Enter to ESC for closing a shape Fix: Change CTRL+Enter to ENTER for closing a shape May 12, 2025
@Pratik-050
Copy link

Hello @M-DEV-1 Why are we making this change from CTRL+Enter to Enter?
And the CTRL+Enter works for me please confirm if the described behaviour in the issue is correct. Thanks!

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 13, 2025

Hi @Pratik-050, the original implementation works for most but some users may face this issue on their devices, I think it might be limited to macs but I'm not sure.

Ctrl+Enter would open the instructions modal. It would be nice to have Esc or Double Click as options too but Esc might minimize the windows on Mac, and double click might not be very friendly for accurately closing shapes.

ref: https://mesheryio.slack.com/archives/C02F90W866T/p1747066526139559?thread_ts=1747066526.139559&cid=C02F90W866T

@Pratik-050
Copy link

Alright @M-DEV-1 but just I think double click will make most sense in this context. Let's see what others think!

@LibenHailu
Copy link

LGTM!

@leecalcote
Copy link
Member

Unless you're still using CTL+ENTER, please update the PR title.

If you're still using that combo.... yikes.

@M-DEV-1 M-DEV-1 changed the title Fix: Change CTRL+Enter to ENTER for closing a shape Fix: use ENTER to close a shape May 20, 2025
@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 20, 2025

@leecalcote no, the combo is not being used anymore 👍🏼

@leecalcote leecalcote merged commit 7847be2 into meshery-extensions:master May 28, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTL+Enter doesn't close the shape, but displays the instruction modal.

4 participants