Skip to content

Conversation

@M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented May 13, 2025

Notes for Reviewers

Modified ESLint Workflow and made changes suggested by the linter.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label May 13, 2025
Copy link

@fahdfady fahdfady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! it's a good note to use npm install here to ensure everything would work correctly

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 20, 2025

Yes, thanks for the input, @fahdfady.

I'm not entirely sure if NODE_ENV=test is strictly required since I'm running npm install to get all the project dependencies but I've still added it because of these errors:

0:0  error  Parsing error: [BABEL] /home/runner/work/shape-builder/shape-builder/site/src/components/Footer/index.js: 

babel-preset-gatsby has been loaded, which consumes config generated by the Gatsby CLI.

Set NODE_ENV=test to bypass, or run gatsby build first. 
 
(While processing: "/home/runner/work/shape-builder/shape-builder/site/node_modules/babel-preset-gatsby/index.js")

@leecalcote
Copy link
Member

Merge conflict...

M-DEV-1 added 2 commits May 29, 2025 01:58
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
@M-DEV-1 M-DEV-1 force-pushed the M-DEV-1/fix-eslint branch from 1a2f5fb to 0c5fff6 Compare May 28, 2025 20:32
@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 28, 2025

@leecalcote I resolved the merge conflicts, and the eslint-workflow seems to be working now.

@leecalcote leecalcote merged commit ff53045 into meshery-extensions:master May 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Continuous integration | Build and release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ESLint Checks are failing

3 participants