Skip to content

Fix SVG.js loading issue #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
M-DEV-1 wants to merge 2 commits into from
Closed

Fix SVG.js loading issue #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9932e0
fix: unused react import in gatsby-ssr.js
M-DEV-1 May 20, 2025
a651f48
fix: error message loading issue by adding more retries
M-DEV-1 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions site/gatsby-srr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import React from "react";

export const onRenderBody = ({ setHeadComponents }) => {
setHeadComponents([
<script key="svg-js" src="/js/svg.min.js" async={false} />,
Expand Down
29 changes: 12 additions & 17 deletions site/src/components/ShapeBuilder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,27 +138,22 @@ const ShapeBuilder = () => {
};

useEffect(() => {
const checkSVG = () => {
if (!window.SVG || !window.SVG.Element.prototype.draw) {
let retries = 0;
Copy link
Member Author

@M-DEV-1 M-DEV-1 May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of checking once after 1 second, it will now check every 200ms for 2 seconds to avoid premature errors.

Copy link
Member

@leecalcote leecalcote May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Hmm. Hmm.

const maxRetries = 10;
const interval = 200;

const waitForSVG = () => {
if (window.SVG && window.SVG.Element.prototype.draw) {
initializeDrawing();
} else if (retries < maxRetries) {
retries++;
setTimeout(waitForSVG, interval);
} else {
setError("SVG.js or svg.draw.js plugin not loaded");
return false;
}
return true;
};

// Initial check
if (checkSVG()) {
initializeDrawing();
} else {
// If not loaded, try again after a short delay
const timer = setTimeout(() => {
if (checkSVG()) {
initializeDrawing();
}
}, 1000);

return () => clearTimeout(timer);
}
waitForSVG();

return () => {
detachKeyListeners();
Expand Down
Loading