Fix proxy_set_header for websocket and custom override locations - #53
Fix proxy_set_header for websocket and custom override locations#53mesudip wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a ProxyHeaderProcessor to manage the reinsertion of default proxy headers when custom headers are injected or for websocket locations. It also updates the Jinja2 template to conditionally render these headers and adds comprehensive unit tests. The review feedback highlights a fragile type check in ProxyHeaderProcessor where checking for list instead of str can break other iterable types. Additionally, it suggests simplifying both the Python logic and the Jinja2 template by treating all websocket locations as requiring header reinsertion, which would eliminate redundant hardcoded blocks in the template.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 70.31% 70.61% +0.29%
==========================================
Files 31 32 +1
Lines 3261 3301 +40
Branches 542 550 +8
==========================================
+ Hits 2293 2331 +38
- Misses 801 802 +1
- Partials 167 168 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.