fix: invert y-axis label row index to match plot orientation#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110.
Summary
TickSet.updatePositionsstored tick positions usingmapToResolutiondirectly, which puts the smallest value at position 0.mapY(used for drawing the data) flips the coordinate so the largest value lands at screen row 0, leaving the y-axis labels mirrored relative to the plot.renderPlotRownow looks up the tick label byplot_height - 1 - row_index, matching the rendered plot orientation (largest value at top, smallest at bottom)._ = plot_heightdiscard now that the parameter is used.Test plan
zig build run-charts(or equivalent) and confirm y-axis labels are ordered largest at top, smallest at bottom.show_labels = falsestill render unchanged.