Fix: C++20 compatibility for modern compilers (GCC 10+)#264
Open
addadi wants to merge 1 commit intomicmacIGN:masterfrom
Open
Fix: C++20 compatibility for modern compilers (GCC 10+)#264addadi wants to merge 1 commit intomicmacIGN:masterfrom
addadi wants to merge 1 commit intomicmacIGN:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a series of compilation errors that occur when building Micmac with modern C++ compilers (e.g., GCC 10 and newer) that enforce C++20 standards.
The build would fail at various stages, making it impossible to compile on up-to-date systems like arch linux
This PR fixes these issues by:
Pt2d,Pt3d,Buf_Fonc_OB_TPL, etc.) from the oldClassName<Type>()form to the C++20-compliantClassName()syntax.img.Size()toimg.size().Ply.h,SparseMatrix.inl) that were referring to non-existent class members.These changes allow Micmac to be compiled successfully with modern toolchains.
Testing:
Successfully compiled the entire project on arch linux with gcc (GCC) 15.1.1 20250425