Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Targeted navigation header fix with tests; workspace dependency pins are tooling-only with no runtime behavior change beyond goto header filtering.
Overview
@browserless/gotono longer passessec-fetch-*headers throughsetExtraHTTPHeaders. User-supplied headers are kept asrawHeadersfor device/user-agent logic, then any key starting withsec-fetch-is dropped before extra HTTP headers are applied so Chrome can set correct per-request metadata (e.g. cross-originfetchis not stuck with navigation-stylesame-originvalues).Monorepo packages switch internal
@browserless/*andbrowserlessdependencies from pinned^13.xversions toworkspace:*. New unit tests inpackages/goto/test/unit/headerscover filtering and cross-origin subrequests.Reviewed by Cursor Bugbot for commit 64fba54. Bugbot is set up for automated code reviews on this repo. Configure here.