webrepl: send Content-Type: text/html for index#1076
webrepl: send Content-Type: text/html for index#1076allisonkarlitskaya wants to merge 1 commit intomicropython:masterfrom
Conversation
allisonkarlitskaya
force-pushed
the
webrepl-content-type
branch
2 times, most recently
from
40bd13f to
fa45c55
Compare
|
friendly nudge |
Josverl
left a comment
Josverl
left a comment
There was a problem hiding this comment.
I support adding the header as IAFAIK it is actually required according the the current HTML specs , but other browsers have implemented content sniffing when it is absent.
micropython/net/webrepl/webrepl.py
Outdated
| cl.send( | ||
| b"""\ | ||
| HTTP/1.0 200 OK\r | ||
| Content-Type: text/html\r |
There was a problem hiding this comment.
This seems to be requirement based on Firefox's strict MIME compliance
If we are adding this tt would make sense to also explicitly add the encoding
Content-Type: text/html; charset=utf-8
Possible in a separate commit.
There was a problem hiding this comment.
Changed as requested!
If we don't do this then Firefox incorrectly guesses text/plain and just shows the source. Adding the Content-Type: fixes the issue. Signed-off-by: Allison Karlitskaya <allison.karlitskaya@redhat.com>
allisonkarlitskaya
force-pushed
the
webrepl-content-type
branch
from
fa45c55 to
381c294
Compare
|
Thanks for the review! I'm unable to merge this for myself |
One of maintainers will need to do that. |
2 participants
If we don't do this then Firefox incorrectly guesses text/plain and just shows the source. Adding the Content-Type: fixes the issue.