Workspace Compilation Follow-up - Add support for BCPT and Upgrade Tests#2186
Open
aholstrup1 wants to merge 17 commits intomainfrom
Open
Workspace Compilation Follow-up - Add support for BCPT and Upgrade Tests#2186aholstrup1 wants to merge 17 commits intomainfrom
aholstrup1 wants to merge 17 commits intomainfrom
Conversation
aholstrup1
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing pieces to workspace compilation so upgrade testing and AppSourceCop baselines can use previous-release apps, and extends workspace compilation to BCPT test folders.
Changes:
- Introduces a new
DownloadPreviousReleasecomposite action and wires it into project build templates. - Passes
previousAppsPaththroughCompileAppsandRunPipeline, and updates logic to consume previously-downloaded apps for upgrade scenarios. - Adds
New-AppSourceCopJsongeneration and BCPT compilation support, plus updates docs and tests.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/DownloadPreviousRelease.Action.Test.ps1 | Adds a compile/yaml-contract test for the new action |
| Tests/DetermineProjectsToBuild.Test.ps1 | Minor test adjustment in project build determination |
| Tests/CompileFromWorkspace.Test.ps1 | Adds unit tests for New-AppSourceCopJson behavior |
| Templates/Per Tenant Extension/.github/workflows/_BuildALGoProject.yaml | Downloads previous release and forwards previousAppsPath |
| Templates/AppSource App/.github/workflows/_BuildALGoProject.yaml | Downloads previous release and forwards previousAppsPath |
| Scenarios/settings.md | Updates workspace compilation documentation/requirements |
| Actions/RunPipeline/action.yaml | Adds previousAppsPath input and forwards it to script |
| Actions/RunPipeline/RunPipeline.ps1 | Consumes previousAppsPath for upgrade testing; adjusts workspace compilation folder handling |
| Actions/DownloadPreviousRelease/action.yaml | New composite action definition |
| Actions/DownloadPreviousRelease/README.md | New action documentation |
| Actions/DownloadPreviousRelease/DownloadPreviousRelease.ps1 | Implements previous release discovery/download and outputs path |
| Actions/CompileApps/action.yaml | Adds previousAppsPath input and forwards it to script |
| Actions/CompileApps/Compile.ps1 | Uses previous apps for AppSourceCop baseline and compiles BCPT folders |
| Actions/.Modules/CompileFromWorkspace.psm1 | Adds New-AppSourceCopJson and exports it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mazhelez
reviewed
Apr 1, 2026
Collaborator
mazhelez
left a comment
mazhelez
left a comment
There was a problem hiding this comment.
Minor adjustments might be needed.
Just confirmed with Developer Experience: app ID and version are the only true parts of an app identity.
And, even if documentation is inaccurate, the Name and Publisher should be avoided.
…achePath - Match previous apps by app ID instead of Publisher_Name (handles renames) - Write only Version to AppSourceCop.json (Publisher/Name not mandatory) - Set baselinePackageCachePath in AppSourceCop.json instead of copying apps to package cache - Update tests accordingly
RunPipeline discovers compiled apps via .buildartifacts/ folder, so writing them back to the dependency JSON files is unnecessary.
- Fix ValidateSet for AppType to include 'bcptApp' - Gate previous apps copy on skipUpgrade AND enableAppSourceCop - Add behavioral tests for DownloadPreviousRelease action - Add regression test for bcptApp AppType - Fail build on previous release download error (exit 1)
aholstrup1
force-pushed
the
aholstrup/workspace_compilation_part2
branch
from
21a035e to
9a76a6d
Compare
mazhelez
approved these changes
Apr 20, 2026
| .PARAMETER AppFolders | ||
| Array of app folder paths to generate AppSourceCop.json for. | ||
| .PARAMETER PreviousApps | ||
| Array of file paths to previous release .app files. |
Collaborator
There was a problem hiding this comment.
Minor: naming
How about baselineApps?
| @@ -0,0 +1,27 @@ | |||
| # Download Previous Release | |||
Collaborator
There was a problem hiding this comment.
Minor: naming
Maybe "Download Latest Release"?
You could also mention that the latest release is branch-specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
This PR addresses a few follow-up items for supporting workspace compilation. Specifically
Related to AB#620485 and AB#620310
✅ Checklist