fix: Enhance local development setup and fix RBAC issues#141
Open
Harmanpreet-Microsoft wants to merge 4 commits intomicrosoft:devfrom
Open
fix: Enhance local development setup and fix RBAC issues#141Harmanpreet-Microsoft wants to merge 4 commits intomicrosoft:devfrom
Harmanpreet-Microsoft wants to merge 4 commits intomicrosoft:devfrom
Conversation
- Add scripts/validate-prerequisites.ps1 to check tool versions, git submodules, Azure auth, azd environment config, subscription alignment, and Fabric/Purview feature readiness before deployment - Add .env.example as a documented reference of all environment variables used by azd and infra/main.bicepparam (not auto-loaded by azd) - Add docs/local_development.md with step-by-step local setup guide, deployment instructions, troubleshooting, and recommended first-run config - Update .devcontainer/devcontainer.json with postCreateCommand to auto-init submodules and run prerequisite validation on container creation - Update README.md to reference the new local development guide Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The RBAC script resolved workspace name from desiredFabricWorkspaceName before FABRIC_WORKSPACE_NAME. In BYO mode these differ, causing the Fabric API lookup to fail silently and skip the Contributor role grant. The OneLake indexer then fails with 'access to the workspace was denied'. Changes: - 01_setup_rbac.ps1: Prefer FABRIC_WORKSPACE_NAME over desiredFabricWorkspaceName. Resolve FABRIC_WORKSPACE_ID and pass it. - setup_ai_services_rbac.ps1: Accept -FabricWorkspaceId parameter. Use it directly for role assignment, skip displayName lookup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…elopment.md to origin/dev state Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801 and
toherman-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enhances the robustness and usability of the OneLake Index RBAC setup scripts and introduces a new script to validate local development prerequisites. The main improvements focus on reliably resolving and using Fabric workspace IDs (especially for BYO scenarios), improving error handling and logging, and providing a comprehensive pre-deployment validation tool.
Key changes include:
Fabric Workspace RBAC Handling Improvements:
01_setup_rbac.ps1now prefers the actual Fabric workspace ID (FABRIC_WORKSPACE_ID) over the display name, making role assignments more reliable and less prone to issues in BYO (Bring Your Own) workspace scenarios. The script now attempts to resolve the workspace ID from multiple sources before falling back to the display name. [1] [2]setup_ai_services_rbac.ps1script now accepts an optionalFabricWorkspaceIdparameter. If provided, it uses this ID directly for role assignments, bypassing the previous fragile lookup by display name. This change also enhances logging to clarify which identifier is being used. [1] [2] [3] [4] [5] [6] [7]01_setup_rbac.ps1have been updated to include the workspace ID when available, improving transparency and troubleshooting. [1] [2]Development Experience Enhancements:
validate-prerequisites.ps1that checks for required tools, repository state, Azure authentication, environment configuration, and feature readiness before deployment. This script helps developers catch common setup issues early, improving deployment reliability and onboarding experience.These changes collectively make the deployment process more robust, especially in complex or BYO environments, and provide better guidance and diagnostics for developers.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information