Migrate from CommandLineParser to System.CommandLine#1941
Merged
tyrielv merged 1 commit intomicrosoft:masterfrom Apr 15, 2026
Merged
Migrate from CommandLineParser to System.CommandLine#1941tyrielv merged 1 commit intomicrosoft:masterfrom
tyrielv merged 1 commit intomicrosoft:masterfrom
Conversation
tyrielv
changed the title
tyrielv
force-pushed
the
tyrielv/net10-system-commandline
branch
3 times, most recently
from
4aa10aa to
72ff548
Compare
Replace reflection-based CommandLineParser 2.6.0 with Microsoft's System.CommandLine 2.0.5 stable release. This eliminates runtime reflection for CLI parsing, a prerequisite for NativeAOT compilation. All 16 GVFS verbs, FastFetch, GVFS.Mount, and LockHolder migrated. Uses SetAction+ParseResult pattern (2.0.x stable API). Shared helpers in GVFSVerb reduce boilerplate while preserving per-verb option binding. Replaces System.CommandLine's built-in --version (assembly reflection, not AOT-safe) with custom --version option routing to same code as 'gvfs version' subcommand via ProcessHelper.GetCurrentProcessVersion(). Adds 'help' subcommand for backward compatibility with old CLI. Case-insensitive verb matching preserved via args normalization. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/net10-system-commandline
branch
from
72ff548 to
f0c8cb8
Compare
derrickstolee
approved these changes
Apr 15, 2026
Contributor
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
If this passes functional tests without actually changing how those tests execute the CLI, then I call that a win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from CommandLineParser to System.CommandLine
Summary
Replace reflection-based CommandLineParser 2.6.0 with Microsoft's System.CommandLine latest stable release. This eliminates runtime reflection for CLI parsing, a prerequisite for NativeAOT compilation.
What changed
[Verb]/[Option]/[Value]attributes, addedCreateCommand()withSetAction(ParseResult)patternRootCommandParser.ParseArgumentswithRootCommand.Parse(args).Invoke()SetActionForVerbWithEnlistment<T>,SetActionForNoEnlistment<T>) with per-verb(verb, result) =>callback for option bindingCommandLineParser→System.CommandLineversionsubcommand —gvfs versionwas handled by CommandLineParser as a built-in pseudo-verb; recreated as explicit subcommand usingProcessHelper.GetCurrentProcessVersion()--versionredirects toversion— rewritten toargs[0] = "version"before parsing, so both use the same code path (AOT-safe, no assembly reflection)helpsubcommand —gvfs help [subcmd]for parity with old parser (additive)args[0]lowercased before parse, matching oldCaseSensitive = false--help/-h/-?handled automatically by System.CommandLineReview guide
--versionredirect (line ~20), case normalization (line ~28), exit code parity withReturnCodemodel(verb, result) =>callback binds all verb-specific options beforeExecute()Option<T>should have a matchingGetValue()assignmentVerification
using CommandLine;or[Verb]/[Option]/[Value]attributesContext
Phase 2B of .NET 10 NativeAOT migration.