Split WSLCCreateSession event - #41327
Open
Craig Loewen (craigloewen-msft) wants to merge 1 commit into
Open
Conversation
Copilot started reviewing on behalf of
Craig Loewen (craigloewen-msft)
August 12, 2026 17:39
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WSL service telemetry in WSLCSessionManagerImpl::CreateSession to split the caller image name out of the existing session-creation event into a dedicated event, enabling easier filtering by caller information.
Changes:
- Ends the existing
WSLCCreateSessionTraceLogging event before emitting caller-related data. - Adds a new
WSLCCreateSessionCallerTraceLogging event that containsCallerFileName.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+367
to
372
| WSL_LOG( | ||
| "WSLCCreateSessionCaller", | ||
| TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage), | ||
| TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), | ||
| TraceLoggingValue(callerFileName.c_str(), "CallerFileName"), | ||
| TraceLoggingLevel(WINEVENT_LEVEL_INFO)); |
Blue (OneBlue)
approved these changes
Aug 12, 2026
Member
|
I don't have the full context I guess, but why are two events preferable to one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Split the WSLCCreateSessionEvent's CallerInfo to its own event for easier filtering
PR Checklist
Detailed Description of the Pull Request / Additional comments
Small change to split the event.
Validation Steps Performed
Clang format and compiling.