Skip to content

CLI: Add --mount support for create and run #41337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
David Bennett (dkbennett) wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

CLI: Add --mount support for create and run #41337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d83f302
Add --mount flag to container run/create
dkbennett Jun 24, 2026
5b413d0
Update and refactor
dkbennett Aug 12, 2026
7d9c1b6
Merge branch 'master' into user/dkbennett/mount-v2
dkbennett Aug 12, 2026
8267ea0
Refactor mount spec location
dkbennett Aug 12, 2026
5d4212c
PR feedback and format fix
dkbennett Aug 13, 2026
f10b961
Remove magic number, fix headers
dkbennett Aug 13, 2026
2fa0e3f
Refactor
dkbennett Aug 13, 2026
241ff02
Update for PR feedback, MountHosts support
dkbennett Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions localization/strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2471,6 +2471,14 @@ For privacy information about this product please visit https://aka.ms/privacy.<
<value>Failed to create volume '{}': {}</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name="MessageWslcBindSourcePathNotFound" xml:space="preserve">
<value>Bind source path does not exist: '{}'</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name="MessageWslcBindSourcePathError" xml:space="preserve">
<value>Failed to access bind source path '{}': {}</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name = "MessageWslcTooManyVirtioFsShares" xml:space = "preserve" >
<value>Too many volumes have been mounted (limit: {}). Restart the session to mount more volumes. This will be fixed in a future release.</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
Expand Down Expand Up @@ -2975,6 +2983,95 @@ On first run, creates the file with all settings commented out at their defaults
<data name="WSLCCLI_InvalidFilterError" xml:space="preserve">
<value>Invalid argument "{}" for '-f, --filter' flag: bad format of filter (expected name=value)</value>
<comment>{FixedPlaceholder="{}"}{Locked="--filter'"}Command line arguments, file names and string inserts should not be translated</comment> </data>
<data name="WSLCCLI_InvalidMountError" xml:space="preserve">
<value>Invalid argument "{}" for '--mount' option: {}</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}{Locked="--mount'"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_UnsupportedMountError" xml:space="preserve">
<value>Argument "{}" for '--mount' option uses an unsupported feature: {}</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}{Locked="--mount'"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_DuplicateMountDestinationError" xml:space="preserve">
<value>Duplicate mount point: {}</value>
<comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountMalformedCsvError" xml:space="preserve">
<value>The CSV input is malformed.</value>
<comment>{Locked="CSV"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountFieldKeyValueRequiredError" xml:space="preserve">
<value>The field '{}' must be a key=value pair.</value>
<comment>{FixedPlaceholder="{}"}{Locked="key=value"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountUnexpectedKeyError" xml:space="preserve">
<value>The key '{}' is unexpected in '{}'.</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountInvalidValueError" xml:space="preserve">
<value>The value for '{}' is invalid: '{}'.</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountInvalidBindRecursiveValueError" xml:space="preserve">
<value>The value for '{}' is invalid: '{}'. Valid values are "enabled", "disabled", "writable", and "readonly".</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}{Locked="enabled"}{Locked="disabled"}{Locked="writable"}{Locked="readonly"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountTypeRequiredError" xml:space="preserve">
<value>The mount type is required.</value>
</data>
<data name="WSLCCLI_MountOptionFamilyMismatchError" xml:space="preserve">
<value>Options matching '{}' cannot be used with mount type '{}'.</value>
<comment>{FixedPlaceholder="{}"}{FixedPlaceholder="{}"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountOptionRequiresReadonlyError" xml:space="preserve">
<value>Option '{}' requires the 'readonly' option.</value>
<comment>{FixedPlaceholder="{}"}{Locked="readonly"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountBindRecursiveReadonlyRequiresPropagationError" xml:space="preserve">
<value>Option 'bind-recursive=readonly' requires the 'bind-propagation=rprivate' option.</value>
<comment>{Locked="bind-recursive=readonly"}{Locked="bind-propagation=rprivate"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountTypeUnsupportedError" xml:space="preserve">
<value>Mount type '{}' is not supported.</value>
<comment>{FixedPlaceholder="{}"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountOptionUnsupportedError" xml:space="preserve">
<value>Option '{}' is not supported.</value>
<comment>{FixedPlaceholder="{}"}Command line arguments and string inserts should not be translated</comment>
</data>
<data name="WSLCCLI_MountTargetRequiredError" xml:space="preserve">
<value>The mount target is required.</value>
</data>
<data name="WSLCCLI_MountTargetAbsoluteError" xml:space="preserve">
<value>The mount target path must be absolute.</value>
</data>
<data name="WSLCCLI_MountTmpfsOptionsTypeError" xml:space="preserve">
<value>The tmpfs options are supported only for tmpfs mounts.</value>
<comment>{Locked="tmpfs"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountTmpfsSizeNegativeError" xml:space="preserve">
<value>The tmpfs size cannot be negative.</value>
<comment>{Locked="tmpfs"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountSourceRequiredError" xml:space="preserve">
<value>The mount source is required.</value>
</data>
<data name="WSLCCLI_MountBindSourceAbsoluteError" xml:space="preserve">
<value>The bind source path must be absolute.</value>
<comment>{Locked="bind"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountAnonymousVolumeUnsupportedError" xml:space="preserve">
<value>Anonymous volume mounts are not supported.</value>
</data>
<data name="WSLCCLI_MountVolumeSourceInvalidError" xml:space="preserve">
<value>The volume source must be a valid named volume.</value>
</data>
<data name="WSLCCLI_MountTmpfsSourceUnsupportedError" xml:space="preserve">
<value>The source option is not supported for tmpfs mounts.</value>
<comment>{Locked="tmpfs"}Command line arguments should not be translated</comment>
</data>
<data name="WSLCCLI_MountTypeUnsupportedGenericError" xml:space="preserve">
<value>The mount type is not supported.</value>
</data>
<data name="WSLCCLI_FollowArgDescription" xml:space="preserve">
<value>Follow log output</value>
</data>
Expand Down Expand Up @@ -3043,6 +3140,9 @@ On first run, creates the file with all settings commented out at their defaults
<value>Memory limit (e.g. 512M, 1G)</value>
<comment>{Locked="512M"}{Locked="1G"}Command line argument example values should not be translated</comment>
</data>
<data name="WSLCCLI_MountArgDescription" xml:space="preserve">
<value>Attach a filesystem mount to the container</value>
</data>
<data name="WSLCCLI_HostnameArgDescription" xml:space="preserve">
<value>Container host name</value>
</data>
Expand Down
2 changes: 2 additions & 0 deletions src/windows/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ set(SOURCES
LxssMessagePort.cpp
LxssSecurity.cpp
LxssServerPort.cpp
MountSpecParsing.cpp
NatNetworking.cpp
notifications.cpp
Redirector.cpp
Expand Down Expand Up @@ -111,6 +112,7 @@ set(HEADERS
LxssPort.h
LxssSecurity.h
LxssServerPort.h
MountSpecParsing.h
NatNetworking.h
notifications.h
precomp.h
Expand Down
Loading