Skip to content

New SDCAVAD sample#1340

Merged
5an7y-Microsoft merged 1 commit intomicrosoft:mainfrom
darugeri:master
Feb 12, 2026
Merged

New SDCAVAD sample#1340
5an7y-Microsoft merged 1 commit intomicrosoft:mainfrom
darugeri:master

Conversation

@darugeri
Copy link
Contributor

@darugeri darugeri commented Nov 25, 2025

No description provided.

@darugeri darugeri requested a review from a team as a code owner November 25, 2025 19:01
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2025
View reviewed changes
audio/SoundWire/Samples/SdcaVad/SdcaVCodec/capture.cpp
DECLARE_CONST_UNICODE_STRING(circuitUri, EXT_CAPTURE_CIRCUIT_URI);

#pragma prefast(suppress:__WARNING_ALIASED_MEMORY_LEAK, "memory is freed by scope_exit")
PSDCAXU_ACX_CIRCUIT_CONFIG exCircuitConfig = (PSDCAXU_ACX_CIRCUIT_CONFIG)ExAllocatePool2(

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
_SDCAXU_ACX_CIRCUIT_CONFIG
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVCodec/render.cpp
DECLARE_CONST_UNICODE_STRING(circuitUri, EXT_RENDER_CIRCUIT_URI);

#pragma prefast(suppress:__WARNING_ALIASED_MEMORY_LEAK, "memory is freed by scope_exit")
PSDCAXU_ACX_CIRCUIT_CONFIG exCircuitConfig = (PSDCAXU_ACX_CIRCUIT_CONFIG)ExAllocatePool2(

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
_SDCAXU_ACX_CIRCUIT_CONFIG
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/CircuitHelper.cpp
RETURN_NTSTATUS_IF_TRUE(pinConnection != nullptr, status);

pinConnectionSize = (ULONG)info;
pinConnection = (PKSPIN_PHYSICALCONNECTION)ExAllocatePool2(POOL_FLAG_NON_PAGED, pinConnectionSize, DRIVER_TAG);

Check warning

Code scanning / CodeQL

Possible information leakage from uninitialized padding bytes. Warning

Memory allocation of
KSPIN_PHYSICALCONNECTION
Loading
includes uninitialized padding bytes.
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/KeywordDetector.cpp
}
}

KeReleaseSpinLock(&m_BufferingStateSpinLock, irql);

Check warning

Code scanning / CodeQL

IRQL too low (C28120) Warning

CKeywordDetector::UpdateBufferingState
Loading
: IRQL potentially too low at call to
KeReleaseSpinLock
Loading
. Minimum IRQL for this call: 2, IRQL at preceding node: 15
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/KeywordDetector.cpp
}
}

KeReleaseSpinLock(&m_BufferingStateSpinLock, irql);

Check warning

Code scanning / CodeQL

IRQL too low (C28120) Warning

CKeywordDetector::NotifyDetection
Loading
: IRQL potentially too low at call to
KeReleaseSpinLock
Loading
. Minimum IRQL for this call: 2, IRQL at preceding node: 15
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/ToneGenerator.cpp
m_PartialFrameBytes = m_FrameSize - (DWORD)length;

Done:
KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/ToneGenerator.cpp
//
// Restore floating state.
//
KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/ToneGenerator.cpp
//
// Restore floating state.
//
KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/WaveReader.cpp
ntStatus = ReadHeaderAndFillBuffer();

Done:
(void)KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
audio/SoundWire/Samples/SdcaVad/SdcaVDsp/WaveReader.cpp
ntStatus = ReadHeaderAndFillBuffer();

Done:
(void)KeRestoreFloatingPointState(&saveData);

Check warning

Code scanning / CodeQL

Irql Float State Mismatch Warning

The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (0) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (2).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (4).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (5).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (6).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (7).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (8).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (9).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (10).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (11).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (12).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (13).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (14).
The irql level where the floating-point state was saved (1) does not match the irql level for the restore operation (15).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (0).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (1).
The irql level where the floating-point state was saved (2) does not match the irql level for the restore operation (3).
The irql level where the floating-point state was saved (2) does not match the irql level f
@darugeri darugeri requested a review from saurinshah9 December 15, 2025 23:05
@5an7y-Microsoft 5an7y-Microsoft self-assigned this Feb 12, 2026
@5an7y-Microsoft
Copy link
Contributor

5an7y-Microsoft commented Feb 12, 2026

All tests are green. Everything else LGTM.

@5an7y-Microsoft 5an7y-Microsoft merged commit 2977346 into microsoft:main Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saurinshah9 saurinshah9 Awaiting requested review from saurinshah9

1 more reviewer

@JuliaDZmura JuliaDZmura JuliaDZmura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@5an7y-Microsoft 5an7y-Microsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darugeri @5an7y-Microsoft @JuliaDZmura @saurinshah9