[1.8-stable] Add IsPackagedProcess and IsSelfContained to common insights PartB fields #6334
[1.8-stable] Add IsPackagedProcess and IsSelfContained to common insights PartB fields #6334agniuks wants to merge 3 commits intorelease/1.8-stablefrom
Conversation
agniuks
changed the title
There was a problem hiding this comment.
no need for this change or the factoring out of appmodel.identity.h or all the project path updates - none of it is used in runtime insights code
| } | ||
|
|
||
| /// Non-throwing variant using dynamic loading (safe before DLL is loaded). | ||
| inline HRESULT IsSelfContained_nothrow(bool& isSelfContained) noexcept |
There was a problem hiding this comment.
not needed - not used in runtime insights
There was a problem hiding this comment.
this file appears to be the only part of this PR that's needed
| enum class TraceLoggingInformationFlags : std::uint32_t | ||
| { | ||
| None = 0, | ||
| IsDebuggerPresent = 0x00000001, |
There was a problem hiding this comment.
this flag factoring is compact - just want to confirm it's actually useful in reports. i.e., can you filter on specific bit values, or is it just an opaque number? if the latter, I'd stick with unique values.
| TraceLoggingString(::Microsoft::WindowsAppRuntime::Insights::RuntimeInformation::WindowsAppRuntimeVersion().c_str(), "Version"), \ | ||
| TraceLoggingString(::Microsoft::WindowsAppRuntime::Insights::RuntimeInformation::WindowsAppRuntimeChannel().c_str(), "WindowsAppSDKChannel"), \ | ||
| TraceLoggingBool(wil::details::IsDebuggerPresent(), "IsDebugging"), \ | ||
| TraceLoggingUInt32(::Microsoft::WindowsAppRuntime::Insights::RuntimeInformation::TraceLoggingInformationFlags(), "Flags"), \ |
There was a problem hiding this comment.
This is definitely not contained. For that reason alone, I'd go with conditional logging of separate bools. Probably makes reporting easier too.
2 participants
CP'ing: c95ecb4
Will give us a better idea of packaged vs unpackaged and self-deployed vs FWP dependent app split in the wild.