Skip to content

[monobuild] Guard 'Get build revision number' against non-date build numbers (fix Foundation stage) #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kyaw Thant (kythant) wants to merge 2 commits into
base: release/dev/monobuild
Choose a base branch
from
Draft

[monobuild] Guard 'Get build revision number' against non-date build numbers (fix Foundation stage) #6649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad05af8
[monobuild] Guard 'Get build revision number' against non-date build …
kythant Jul 23, 2026
4be5544
Also guard the duplicate build-number Substring in BuildAll.ps1
kythant Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions BuildAll.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,23 @@ Try {
$env:BUILD_BUILDNUMBER = $env:TFS_BUILDNUMBER
}
Write-Host "BuildNumber : " $env:BUILD_BUILDNUMBER
$yymm = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 10, 4)
$dd = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 5, 2)
$revision = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 3, 3)
# The pipeline-name scheme $(date:yyMM).$(date:dd)$(rev:rrr) yields a >=10-char build number, so
# the fixed end-offsets below are valid. The mono-build instead passes a short semantic build
# number (e.g. "2.0.0"), where Foundation is versioned from $(WindowsAppSDKFormattedVersion).
# Guard the offsets so a <10-char number can't throw "StartIndex cannot be less than zero".
if ($env:BUILD_BUILDNUMBER.length -ge 10)
{
$yymm = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 10, 4)
$dd = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 5, 2)
$revision = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 3, 3)
}
else
{
Write-Host "BUILD_BUILDNUMBER '$env:BUILD_BUILDNUMBER' has no embedded date (mono-build); using zero build/revision."
$yymm = '0000'
$dd = '00'
$revision = '000'
}

$WindowsAppSDKVersionProperty = "/p:WindowsAppSDKVersionBuild=$yymm /p:WindowsAppSDKVersionRevision=$dd$revision"

Expand Down
21 changes: 18 additions & 3 deletions build/AzurePipelinesTemplates/WindowsAppSDK-SetupBuildEnvironment-Steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,24 @@ steps:
{
$env:BUILD_BUILDNUMBER = $env:TFS_BUILDNUMBER
}
$yymm = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 10, 4)
$dd = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 5, 2)
$revision = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 3, 3)
# The pipeline-name scheme $(date:yyMM).$(date:dd)$(rev:rrr) yields a >=10-char build number, so
# the fixed end-offsets below are valid. The mono-build instead passes a short semantic build
# number (e.g. "2.0.0"), where Foundation is versioned from $(WindowsAppSDKFormattedVersion) and
# these date/revision values are unused. Guard the offsets so a <10-char number can't throw
# "StartIndex cannot be less than zero" (build 152839452, mono-build Official "2.0.0").
if ($env:BUILD_BUILDNUMBER.length -ge 10)
{
$yymm = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 10, 4)
$dd = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 5, 2)
$revision = $env:BUILD_BUILDNUMBER.substring($env:BUILD_BUILDNUMBER.length - 3, 3)
}
else
{
Write-Host "BUILD_BUILDNUMBER '$env:BUILD_BUILDNUMBER' has no embedded date (mono-build); using zero builddate/revision."
$yymm = '0000'
$dd = '00'
$revision = '000'
}
Write-Host "##vso[task.setvariable variable=builddate]$yymm$dd"
Write-Host "##vso[task.setvariable variable=builddate_yymm]$yymm"
Write-Host "##vso[task.setvariable variable=builddate_dd]$dd"
Expand Down