fix(images): use effective repos for ISO build - #18648
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ISO package sourcing to use repositories from Kiwi’s effective configuration.
Changes:
- Parses build repositories from
/image/config.xml. - Adds explicit Python 3 dependency.
- Dynamically configures DNF repository arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
base/images/vm-iso-installer/config.sh |
Builds the offline repository from Kiwi-selected sources. |
base/images/vm-iso-installer/vm-iso-installer.kiwi |
Adds Python 3 and updates repository documentation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
reuben olinsky (reubeno)
marked this pull request as ready for review
August 28, 2026 03:38
Tobias Brick (tobiasb-ms)
requested changes
Aug 28, 2026
Read the effective repositories from Kiwi's imported image description instead of duplicating the Azure Linux CDN URL in config.sh. This uses the repositories selected by the Koji task while preserving local image builds, where the imported description contains the configured Azure Linux repository. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a8a571f0-e745-492a-8ce1-23b818f3b51e
reuben olinsky (reubeno)
force-pushed
the
fix-iso-build
branch
from
August 28, 2026 18:58
b38078c to
ce2ef68
Compare
| # configured Azure Linux repo and Koji builds use the repos selected by the task. | ||
| # Kiwi includes imageonly repos in the finished appliance but does not use | ||
| # them during the build. Exclude them so this mirrors Kiwi's package inputs. | ||
| BUILD_REPO_XPATH="/image/repository[not(translate(@imageonly, 'TRUE', 'true') = 'true')]/source[@path != '']/@path" |
Tobias Brick (tobiasb-ms)
approved these changes
Aug 28, 2026
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the effective repositories from Kiwi's imported image description instead of duplicating the Azure Linux CDN URL in
config.sh. This will align the ISO build's consumption of packages with other images, and as a side effect, correct theISO build for PME-prod.
This uses the repositories selected by the Koji task while preserving local image builds, where the imported description contains the configured Azure Linux repository.
Adds
libxml2as an explicit dependency to ensure xmllint is present.Validation
Validated with local build as well as with a scratch koji build. In both cases the updated logic in
config.shcorrectly identified the correct repository to pull packages from.