fix: make fnllm utils fork-safe for Celery workers#1975
Open
droideronline wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: make fnllm utils fork-safe for Celery workers#1975droideronline wants to merge 2 commits intomicrosoft:mainfrom
droideronline wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Detect process forks and recreate thread resources to prevent 'RuntimeError: threads can only be started once' in worker processes. - Add PID tracking for fork detection - Safe cleanup of inherited resources - Fresh event loop creation per process
Author
@microsoft-github-policy-service agree |
Author
|
@natoverse - Could you please review this PR when you have some time. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect process forks and recreate thread resources to prevent 'RuntimeError: threads can only be started once' in worker processes.
Problem
GraphRAG fails in Celery worker processes with
RuntimeError: threads can only be started oncewhen executing queries that use embedding models. This occurs because the currentrun_coroutine_sync()implementation is not fork-safe.Root Cause
When Celery creates worker processes by forking:
_thr,_loop,_pid)_thr.start()on a dead thread objectSolution
This PR implements fork detection and safe resource recreation:
contextlib.suppress()to safely cleanup inherited resourcesChanges Made
Modified Files:
graphrag/language_model/providers/fnllm/utils.pyRelated Issues
#1974
Proposed Changes
osandcontextlibfor PID tracking and safe cleanuprun_coroutine_sync(): Added fork detection logicChecklist