Fix LanceDB db_uri validation check#1991
Open
mohiuddin-khan-shiam wants to merge 3 commits intomicrosoft:mainfrom
Open
Fix LanceDB db_uri validation check#1991mohiuddin-khan-shiam wants to merge 3 commits intomicrosoft:mainfrom
mohiuddin-khan-shiam wants to merge 3 commits intomicrosoft:mainfrom
Conversation
…hrag/graphrag/config/models/graph_rag_config.py:293:4-300:82) validation check The [_validate_vector_store_db_uri](cci:1://file:///c:/Users/T2430514/Downloads/graphrag/graphrag/config/models/graph_rag_config.py:293:4-300:82) method compared `store.db_uri.strip` (the method) to an empty string, which was always `False`. As a result, whitespace-only or empty [db_uri](cci:1://file:///c:/Users/T2430514/Downloads/graphrag/graphrag/config/models/graph_rag_config.py:293:4-300:82) values for LanceDB were silently accepted, leading to mis-configured vector-store paths and runtime failures when later resolving or connecting to the database. This patch calls `strip()` before the comparison: ```python if not store.db_uri or store.db_uri.strip() == "": ``` Now the validator correctly rejects blank or whitespace-only URIs, preventing invalid configurations from slipping through and improving overall robustness of the GraphRAG setup process. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
The [_validate_vector_store_db_uri](cci:1://file:///c:/Users/T2430514/Downloads/graphrag/graphrag/config/models/graph_rag_config.py:293:4-300:82) method compared `store.db_uri.strip` (the method) to an empty string, which was always `False`. As a result, whitespace-only or empty [db_uri](cci:1://file:///c:/Users/T2430514/Downloads/graphrag/graphrag/config/models/graph_rag_config.py:293:4-300:82) values for LanceDB were silently accepted, leading to mis-configured vector-store paths and runtime failures when later resolving or connecting to the database. This patch calls `strip()` before the comparison: ```python if not store.db_uri or store.db_uri.strip() == "": ``` Now the validator correctly rejects blank or whitespace-only URIs, preventing invalid configurations from slipping through and improving overall robustness of the GraphRAG setup process.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix LanceDB db_uri validation check
The _validate_vector_store_db_uri method compared
store.db_uri.strip(the method) to an empty string, which was alwaysFalse.As a result, whitespace-only or empty db_uri values for LanceDB were silently accepted, leading to mis-configured vector-store paths and runtime failures when later resolving or connecting to the database.
This patch calls
strip()before the comparison:Now the validator correctly rejects blank or whitespace-only URIs, preventing invalid configurations from slipping through and improving overall robustness of the GraphRAG setup process.