Add lock for writing and reading self.runbook.admin_private_key_file#4285
Merged
Add lock for writing and reading self.runbook.admin_private_key_file#4285
Conversation
lubaihua33
force-pushed
the
baihua/key_path
branch
from
85dade8 to
a689c53
Compare
LiliDeng
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cocurrency is not 1, and admin_private_key_file in the runbook is empty, there might be VM connection issue.
When multiple LISA threads run concurrently, they contend for access to self.runbook.admin_private_key_file. This leads to a race condition during read/write operations. Specifically, if one thread reads admin_private_key_file as empty and begins generating a new key, another thread may do the same before the first thread finishes writing the file path. As a result, multiple keys are generated simultaneously. The VM creation process may use one key, while the connection attempt uses another, causing the VM to become unreachable.
This PR adds a lock for self.runbook.admin_private_key_file