-
Notifications
You must be signed in to change notification settings - Fork 623
Rust build script fixes #5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rust build script fixes #5519
Conversation
|
@nishanthkarthik please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
guhetier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The option for NUMA looks good to me, but stdout by default as the logger might be an issue.
| .define("QUIC_OUTPUT_DIR", quic_output_dir.to_str().unwrap()); | ||
|
|
||
| if cfg!(unix) && cfg!(feature = "logging") { | ||
| config.define("QUIC_LOGGING_TYPE", "stdout"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging using stdout is a big performance hit, it should not be a default.
lttng would be better, with stdout taking some explicit opt-in.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5519 +/- ##
==========================================
+ Coverage 84.81% 85.28% +0.47%
==========================================
Files 60 60
Lines 18647 18647
==========================================
+ Hits 15816 15904 +88
+ Misses 2831 2743 -88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When msquic is built with `static` feature in Rust, `build.rs`
expects `libnuma.a` at hardcoded paths. Not all distributions
provide a packaged libnuma.a, or place them under
`/usr/lib/{triple}`. Moving libnuma behind a flag lets the user
make a completely static build without numa.
66c452e to
0f9b8ac
Compare
Description
staticfeature is enabled but libnuma is missingSee commit messages for more explanation
Testing
This PR does not (and should not) change any defaults. Fixes are opt-in through feature flags.
Documentation
Not sure