Fix some flakyness in QuicTestOperationPriority #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QuicTestOperationPriorityrelied on the number of stream bytes sent from the statistic data to determine if a send operation completed or not.This is incorrect, as the number of bytes is updated in the stats only after a
FLUSH_SENDoperation. It left room for some situations where theGET_PARAMoperation could run between theSTREAM_SENDand theFLUSH_SEND, causing a spurious test failure.The test now relies on the
STREAM_SEND_COMPLETEindication.Testing
CI
Documentation
N/A. Comment added to the test code.