-
Notifications
You must be signed in to change notification settings - Fork 291
Add prebuilt binaries #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @Tyriar! I did at least manage to get the tests green on CI with b7e506d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add node scripts/prebuild.js --populate to azure-pipelines.yml and publish.yml after all npm ci tasks? This file is good for testing but I don't think we want it in the final PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can start with that. I think we'll need a way to run the publish.yml on multiple platforms, and then merge the prebuild/ directories to publish together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it.
The extension template has support for multiple platforms, but the npm package template doesn't. Your ask is also not the same as what the extension template does. Ref https://github.com/microsoft/vscode-jupyter/blob/main/build/azure-pipeline.stable.yml#L26 and CC @lszomoru
Edit: It might be easier for me to create a new pipeline that runs before the publishing pipeline that prepares the binaries.
947531f to
a7508ed
Compare
|
Closing in favor of #804! |
Adds prebuilt binaries to the published npm package.
After looking into using prebuild-install and prebuildify, went with a hand-rolled approach since the gyp build for node-pty was sufficiently unique with all of the different targets and assets.
The last commit is purely for testing via fork and should be dropped before merging.
See example build on forked package: https://www.npmjs.com/package/@devm33/node-pty?activeTab=code
The second to last commit is using GitHub Actions to publish instead of Azure Pipelines since I didn't have access to test there. If Actions is acceptable to use that'd be great! Otherwise will need to port to Pipelines.
cc #46