fix(codegen): use REACT_NATIVE constant for npmPackageName#2956
Open
tvinhas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
'react-native-macos'string atpackages/react-native/react-native.config.js:188with theREACT_NATIVEconstant fromscripts/codegen/generate-artifacts-executor/constants.js. The constant already readspackageJson.nameso the resolved value is unchanged on this fork, but the indirection means future package-name moves (workspace renames, internal rebrand, etc.) don't require remembering this one site.Closes the "Codegen package name constant" item on the Road to 0.83 tracking issue (#2901).
Test Plan
pod installinpackages/rn-testerruns the codegen step end-to-end and resolvesnpmPackageNamewithout errors (validated locally on 0.83-merge).react-native-macos.