Polish command-line help dialog formatting#20294
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
This comment was marked as spam.
This comment was marked as spam.
Member
|
Can you add a screenshot of what this looks like? |
Contributor
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Narrows the generated
wtcommand-line help formatting so the text shown in the help MessageBox wraps at a dialog-friendly width.References and Relevant Issues
Closes #4134
Detailed Description of the Pull Request / Additional comments
The command-line help text is produced by CLI11 before
WindowEmperordisplays it in a MessageBox. This updates the shared CLI formatter to use narrower help columns and a 72-character paragraph width, so top-level and subcommand help avoid long horizontal lines in the fixed-size dialog.The existing command-line help tests now assert that generated help lines stay within that 72-character limit, and the stale GH#4134 TODO at the MessageBox call site has been replaced with a comment pointing to the formatter behavior.
Validation Steps Performed
PR Checklist
msiexec /?#4134