Fix Export Tab leaking Enter via Command Palette#20358
Open
carlos-zamora wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where Enter would leak into the terminal session when running the export buffer command from the command palette.
Turns out this is because
_ExportTab()opens the file picker synchronously in the key handler. The file picker spins a nested Win32 modal message loop, which pumps the queuedWM_CHARinto the terminal.Switching to the foreground thread gets out of the nested modal loop, resulting in the
WM_CHARbeing handled through XAML's pipeline and suppressing it normally. The low priority makes it so that the command palette is visibly dismissed before opening the file picker.Validation Steps Performed
Run export buffer action from the command palette.
✅ Enter does not go through to the underlying terminal.
PR Checklist
Closes #20188
Based on #20221