Skip to content

Fix icon picker file state after selecting None#20388

Open
FuZoe wants to merge 1 commit into
microsoft:mainfrom
FuZoe:codex/fix-icon-picker-file-none
Open

Fix icon picker file state after selecting None#20388
FuZoe wants to merge 1 commit into
microsoft:mainfrom
FuZoe:codex/fix-icon-picker-file-none

Conversation

@FuZoe

@FuZoe FuZoe commented Jul 6, 2026

Copy link
Copy Markdown

Summary of the Pull Request

Fixes the icon picker state transition when switching the profile icon type from File to None and back to File.

References and Relevant Issues

Closes #20307

Detailed Description of the Pull Request / Additional comments

The icon picker now only caches real image icon paths when leaving the File icon type. The none sentinel, built-in glyphs, and emoji values are no longer treated as restorable file paths, so selecting File after None keeps the File controls visible instead of being inferred back to None.

The control also raises the derived icon-type visibility property changes directly whenever the current icon type changes.

Validation Steps Performed

  • Added LocalTests coverage for the IconPicker File -> None -> File state transition.
  • Added LocalTests coverage for restoring the last real image path after switching away from File.
  • git diff upstream/main...HEAD --check

PR Checklist

@FuZoe FuZoe marked this pull request as draft July 6, 2026 07:20
@FuZoe FuZoe force-pushed the codex/fix-icon-picker-file-none branch from 650fdae to af269fa Compare July 6, 2026 07:47
@FuZoe FuZoe marked this pull request as ready for review July 6, 2026 07:48
@FuZoe FuZoe marked this pull request as draft July 6, 2026 07:52
@FuZoe FuZoe marked this pull request as ready for review July 6, 2026 07:56
@FuZoe FuZoe marked this pull request as draft July 6, 2026 08:04
@FuZoe FuZoe marked this pull request as ready for review July 6, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings UI: "Browse" button disappears/fails to appear when switching Icon dropdown from "File" -> "None" -> "File"

1 participant