Fix parsing of as/satisfies between ** operators#4676
Open
magic-akari wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes unsafe erasure of as and satisfies between right-associative exponentiation operators.
Changes:
- Centralizes binary-operator consumption logic.
- Handles equal-precedence
**operators correctly. - Adds direct and chained regression coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/parser/parser.go |
Accounts for exponentiation associativity during parsing. |
testdata/tests/cases/compiler/disallowUnerasableAssertion.ts |
Adds regression cases. |
testdata/baselines/reference/compiler/disallowUnerasableAssertion.errors.txt |
Captures expected diagnostics. |
testdata/baselines/reference/compiler/disallowUnerasableAssertion.js |
Captures JavaScript emit. |
testdata/baselines/reference/compiler/disallowUnerasableAssertion.symbols |
Updates symbol baselines. |
testdata/baselines/reference/compiler/disallowUnerasableAssertion.types |
Updates type baselines. |
mconnectbharat-oss
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4192.
Accounts for
**being right-associative when rejectingas/satisfiesexpressions that cannot be safely erased. Adds regression coverage for direct and chained forms.as/satisfiesbetween exponentiation operators cannot be safely erased TypeScript#63661