fix(4677): preserve JSDoc for mapped type properties in hover#4685
Open
a-tarasyuk wants to merge 2 commits into
Open
fix(4677): preserve JSDoc for mapped type properties in hover#4685a-tarasyuk wants to merge 2 commits into
a-tarasyuk wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves property JSDoc in hover information for mapped types.
Changes:
- Falls back to a symbol’s first declaration when no value declaration exists.
- Adds mapped-type hover coverage and updates expected baselines.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/ls/hover.go |
Adds declaration fallback for hover documentation. |
internal/fourslash/tests/hoverMappedTypePropertyJSDoc_test.go |
Tests local and imported mapped properties. |
testdata/baselines/reference/fourslash/quickInfo/hoverMappedTypePropertyJSDoc.baseline |
Records new hover expectations. |
testdata/baselines/reference/fourslash/quickInfo/quickInfoOnUnionPropertiesWithIdenticalJSDocComments01.baseline |
Updates union-property documentation output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4677