Skip to content

fix(4677): preserve JSDoc for mapped type properties in hover#4685

Open
a-tarasyuk wants to merge 2 commits into
microsoft:mainfrom
a-tarasyuk:fix/4677
Open

fix(4677): preserve JSDoc for mapped type properties in hover#4685
a-tarasyuk wants to merge 2 commits into
microsoft:mainfrom
a-tarasyuk:fix/4677

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #4677

Copilot AI review requested due to automatic review settings July 20, 2026 15:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Preserves property JSDoc in hover information for mapped types.

Changes:

  • Falls back to a symbol’s first declaration when no value declaration exists.
  • Adds mapped-type hover coverage and updates expected baselines.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
internal/ls/hover.go Adds declaration fallback for hover documentation.
internal/fourslash/tests/hoverMappedTypePropertyJSDoc_test.go Tests local and imported mapped properties.
testdata/baselines/reference/fourslash/quickInfo/hoverMappedTypePropertyJSDoc.baseline Records new hover expectations.
testdata/baselines/reference/fourslash/quickInfo/quickInfoOnUnionPropertiesWithIdenticalJSDocComments01.baseline Updates union-property documentation output.

Comment thread internal/ls/hover.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSDoc (TSDoc ???) is not shown for object literal properties on hover

2 participants