Skip to content

[api] Add .getNonMissingTypeOfSymbol() getter#4701

Open
mrazauskas wants to merge 3 commits into
microsoft:mainfrom
mrazauskas:add-getNonMissingTypeOfSymbol
Open

[api] Add .getNonMissingTypeOfSymbol() getter#4701
mrazauskas wants to merge 3 commits into
microsoft:mainfrom
mrazauskas:add-getNonMissingTypeOfSymbol

Conversation

@mrazauskas

Copy link
Copy Markdown
Contributor

Close #4081

This PR adds the .getNonMissingTypeOfSymbol() getter.

Signed-off-by: mrazauskas <tom@mrazauskas.de>
Copilot AI review requested due to automatic review settings July 22, 2026 03:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds getNonMissingTypeOfSymbol to expose symbol types that respect exactOptionalPropertyTypes, addressing #4081.

Changes:

  • Exposes the checker operation through the Go API and protocol.
  • Adds synchronous and asynchronous TypeScript APIs.
  • Tests behavior with exact optional property types enabled and disabled.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/checker/exports.go Exposes the checker method.
internal/api/session.go Handles the new API request.
internal/api/proto.go Registers the protocol method and parameters.
_packages/native-preview/src/api/sync/api.ts Adds the synchronous getter.
_packages/native-preview/src/api/async/api.ts Adds the asynchronous getter.
_packages/native-preview/test/sync/api.test.ts Tests synchronous behavior.
_packages/native-preview/test/async/api.test.ts Tests asynchronous behavior.

Comment thread _packages/native-preview/src/api/sync/api.ts Outdated
Comment thread _packages/native-preview/src/api/async/api.ts Outdated
Comment thread _packages/native-preview/test/sync/api.test.ts Outdated
Comment thread _packages/native-preview/test/async/api.test.ts Outdated
Signed-off-by: mrazauskas <tom@mrazauskas.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API to get symbol type that respects the exactOptionalPropertyTypes option

2 participants